Skip to content

Update Merge Blitz.ps1 so not hardcoded to directory path#3595

Closed
DanielLoth wants to merge 1 commit intoBrentOzarULTD:devfrom
DanielLoth:update-merge-ps1-script
Closed

Update Merge Blitz.ps1 so not hardcoded to directory path#3595
DanielLoth wants to merge 1 commit intoBrentOzarULTD:devfrom
DanielLoth:update-merge-ps1-script

Conversation

@DanielLoth
Copy link

@DanielLoth DanielLoth commented Dec 6, 2024

Overview

This change updates the script such that it'll run on other peoples' machines, even when they don't have a folder path that is specific to Brent's developer machine.

Testing notes

Running Merge Blitz.ps1 from the repository root directory

Command:

& '.\Documentation\Development\Merge Blitz.ps1'

Demo:

PS C:\Dev\SQL-Server-First-Responder-Kit> git status
On branch update-merge-ps1-script
Your branch is up to date with 'origin/update-merge-ps1-script'.

nothing to commit, working tree clean
PS C:\Dev\SQL-Server-First-Responder-Kit> & '.\Documentation\Development\Merge Blitz.ps1'
PS C:\Dev\SQL-Server-First-Responder-Kit> git status
On branch update-merge-ps1-script
Your branch is up to date with 'origin/update-merge-ps1-script'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   Install-All-Scripts.sql
        modified:   Install-Azure.sql

no changes added to commit (use "git add" and/or "git commit -a")

Running Merge Blitz.ps1 from the same directory

Command:

& '.\Merge Blitz.ps1'

Demo:

PS C:\Dev\SQL-Server-First-Responder-Kit\Documentation\Development> git status
On branch update-merge-ps1-script
Your branch is up to date with 'origin/update-merge-ps1-script'.

nothing to commit, working tree clean
PS C:\Dev\SQL-Server-First-Responder-Kit\Documentation\Development> & '.\Merge Blitz.ps1'
PS C:\Dev\SQL-Server-First-Responder-Kit\Documentation\Development> git status
On branch update-merge-ps1-script
Your branch is up to date with 'origin/update-merge-ps1-script'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   ../../Install-All-Scripts.sql
        modified:   ../../Install-Azure.sql

no changes added to commit (use "git add" and/or "git commit -a")

@DanielLoth
Update Merge Blitz.ps1 so not hardcoded to directory path
7c09213 
This change updates the script such that it'll run on other
peoples' machines, even when they don't have a folder path
that is specific to Brent's developer machine.
@BrentOzar
Copy link
Member

BrentOzar commented Dec 6, 2024

Hi, can you tell me a little about the use case for this?

@DanielLoth
Copy link
Author

DanielLoth commented Dec 7, 2024

Hi. Same use case as before - combines the various scripts. But now the correct operation of the script isn't dependent on the repository being checked out to the very specific /Users/brentozar/LocalOnly/Github/SQL-Server-First-Responder-Kit directory path.

@BrentOzar
Copy link
Member

BrentOzar commented Dec 7, 2024 via email

@DanielLoth
Copy link
Author

DanielLoth commented Dec 7, 2024

Oh, I don't. I was just looking through the repo while doing your course on using it, tried to run the script, and found it didn't work.

@BrentOzar
Copy link
Member

BrentOzar commented Dec 14, 2024

OK, gotcha. Let's hold off on changing code without a use case for now, and if you'd like to contribute further, make sure to check out the contribution instructions in the repo. Thanks though!

@BrentOzar BrentOzar closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielLoth @BrentOzar

Comments